-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs/Reporting] More information about HTTP / script stuff #41200
Conversation
Pinging @elastic/kibana-docs |
Pinging @elastic/kibana-app |
|
||
- **`200` (OK)**: As expected, Kibana returns `200` status in the response for | ||
successful requests to queue or download reports. | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: easy-to-miss soft line break here
|
||
If there was an error in generating the report, the download URL will return a 500 | ||
(Internal Server Error) response. More information is available in the | ||
Reporting management page in Kibana: *Management > Kibana > Reporting* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this is moved to a standalone section, because it grew pretty large
💚 Build Succeeded |
💔 Build Failed |
|
||
- **`503` (Service Unavailable)**: When using the `path` to request the download, you will get | ||
a `503` status response if report generation hasn't completed yet. In that case, | ||
retry after the number of seconds in the `Retry-After` header in the download API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is confusing:
In that case, retry after the number of seconds in the Retry-After
header in the download API response until the report is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. How about:
When using the
path
to request the download, you will get a503
status response if report generation hasn't completed yet. A503
response comes with aRetry-After
header. Before trying again to download the report, you can have your script wait the suggested number of seconds found in theRetry-After
header until the report is complete.
Co-Authored-By: gchaps <[email protected]>
… into docs/reporting-post-url
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
…41200) * [Docs/Reporting] More information about HTTP / script stuff * "post url" formatting consistency * consistent wording from 1 paragraph to another * Update docs/reporting/response-codes.asciidoc Co-Authored-By: gchaps <[email protected]> * pr feedback * subs=attributes, version in command example * "Retry-After" content * another feedback
…41200) * [Docs/Reporting] More information about HTTP / script stuff * "post url" formatting consistency * consistent wording from 1 paragraph to another * Update docs/reporting/response-codes.asciidoc Co-Authored-By: gchaps <[email protected]> * pr feedback * subs=attributes, version in command example * "Retry-After" content * another feedback
…41200) * [Docs/Reporting] More information about HTTP / script stuff * "post url" formatting consistency * consistent wording from 1 paragraph to another * Update docs/reporting/response-codes.asciidoc Co-Authored-By: gchaps <[email protected]> * pr feedback * subs=attributes, version in command example * "Retry-After" content * another feedback
…41523) * [Docs/Reporting] More information about HTTP / script stuff * "post url" formatting consistency * consistent wording from 1 paragraph to another * Update docs/reporting/response-codes.asciidoc Co-Authored-By: gchaps <[email protected]> * pr feedback * subs=attributes, version in command example * "Retry-After" content * another feedback
…41524) * [Docs/Reporting] More information about HTTP / script stuff * "post url" formatting consistency * consistent wording from 1 paragraph to another * Update docs/reporting/response-codes.asciidoc Co-Authored-By: gchaps <[email protected]> * pr feedback * subs=attributes, version in command example * "Retry-After" content * another feedback
…41525) * [Docs/Reporting] More information about HTTP / script stuff * "post url" formatting consistency * consistent wording from 1 paragraph to another * Update docs/reporting/response-codes.asciidoc Co-Authored-By: gchaps <[email protected]> * pr feedback * subs=attributes, version in command example * "Retry-After" content * another feedback
💚 Build Succeeded |
Follows #40931
This moves text from an
important
note to its own section:HTTP Response Codes
: